Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String NSRange helpers #1989

Merged
merged 4 commits into from
Sep 14, 2023
Merged

String NSRange helpers #1989

merged 4 commits into from
Sep 14, 2023

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Sep 8, 2023

Task/Issue URL: https://app.asana.com/0/1177771139624306/1205421610519119/f
BSK PR: duckduckgo/BrowserServicesKit#499

Description:

  • updated BSK for macOS PR

@mallexxx mallexxx requested a review from tomasstrba September 8, 2023 10:21
This was referenced Sep 8, 2023
Merged
Merged
tomasstrba
tomasstrba approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@mallexxx mallexxx merged commit de51a97 into develop Sep 14, 2023
@mallexxx mallexxx deleted the alex/string-nsrange branch September 14, 2023 09:12
mallexxx added a commit to duckduckgo/macos-browser that referenced this pull request Sep 14, 2023
@mallexxx
Address bar refactoring (#1610)
b3229e5 
Task/Issue URL:
https://app.asana.com/0/1177771139624306/1205421610519119/f
BSK PR: duckduckgo/BrowserServicesKit#499
iOS PR: duckduckgo/iOS#1989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasstrba tomasstrba tomasstrba approved these changes

Assignees
No one assigned
Labels
includes-BSK-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @tomasstrba